Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update factory to node 20.13.0 and add new GPG key #1045

Merged
merged 1 commit into from
May 8, 2024

Conversation

jahusa02
Copy link
Contributor

@jahusa02 jahusa02 commented May 8, 2024

fixes #1044

@CLAassistant
Copy link

CLAassistant commented May 8, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@jahusa02 jahusa02 force-pushed the feature/node-20.13.0 branch from 41c64a9 to d1875e0 Compare May 8, 2024 11:21
Copy link
Collaborator

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove a previously valid key.

factory/installScripts/node/default.sh Show resolved Hide resolved
@jahusa02 jahusa02 force-pushed the feature/node-20.13.0 branch from d1875e0 to daf4f41 Compare May 8, 2024 12:05
@jahusa02 jahusa02 changed the title chore: update factory to node 20.13.0 and add new/missing GPG key chore: update factory to node 20.13.0 and add new GPG key May 8, 2024
@jahusa02 jahusa02 force-pushed the feature/node-20.13.0 branch from daf4f41 to 0e5f94e Compare May 8, 2024 14:10
Copy link
Collaborator

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennifer-shehane
All tests pass except one failure which is unrelated to the change, so I don't see any blockers for this PR.

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Only thing additionally needed is to bump the version of the factory, which we do whenever we increment the node version. We also need to add a CHANGELOG entry

@MikeMcC399
Copy link
Collaborator

@AtofStryker

Of course, you're right! Sorry for overlooking this when I approved.

@jahusa02 jahusa02 force-pushed the feature/node-20.13.0 branch from 0e5f94e to f20564e Compare May 8, 2024 15:19
@jahusa02
Copy link
Contributor Author

jahusa02 commented May 8, 2024

@AtofStryker

Of course, you're right! Sorry for overlooking this when I approved.

* [Releasing a new version](https://github.com/cypress-io/cypress-docker-images/blob/master/CONTRIBUTING.md#releasing-a-new-factory-version)

I thought it would be okay since I didn't make any changes to the Dockerfile, sorry!

@jahusa02 jahusa02 requested a review from AtofStryker May 8, 2024 15:24
@AtofStryker
Copy link
Contributor

@AtofStryker
Of course, you're right! Sorry for overlooking this when I approved.

* [Releasing a new version](https://github.com/cypress-io/cypress-docker-images/blob/master/CONTRIBUTING.md#releasing-a-new-factory-version)

I thought it would be okay since I didn't make any changes to the Dockerfile, sorry!

no worries thank you for doing this!

@jennifer-shehane jennifer-shehane merged commit c565ef2 into cypress-io:master May 8, 2024
31 checks passed
@jahusa02 jahusa02 deleted the feature/node-20.13.0 branch May 9, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 20.13.0 gpg: Can't check signature: No public key
6 participants