-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update factory to node 20.13.0 and add new GPG key #1045
chore: update factory to node 20.13.0 and add new GPG key #1045
Conversation
|
41c64a9
to
d1875e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove a previously valid key.
d1875e0
to
daf4f41
Compare
daf4f41
to
0e5f94e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jennifer-shehane
All tests pass except one failure which is unrelated to the change, so I don't see any blockers for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. Only thing additionally needed is to bump the version of the factory, which we do whenever we increment the node version. We also need to add a CHANGELOG entry
Of course, you're right! Sorry for overlooking this when I approved. |
also bump factory to v3.5.5
0e5f94e
to
f20564e
Compare
I thought it would be okay since I didn't make any changes to the Dockerfile, sorry! |
no worries thank you for doing this! |
fixes #1044