Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickcheck limited_recover_fail failure? #93

Open
cyphar opened this issue Jul 14, 2024 · 2 comments
Open

quickcheck limited_recover_fail failure? #93

cyphar opened this issue Jul 14, 2024 · 2 comments

Comments

@cyphar
Copy link
Owner

cyphar commented Jul 14, 2024

Just saw this failure.

thread 'shamir::dealer::test::limited_recover_fail' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/quickcheck-1.0.3/src/tester.rs:165:28:
[quickcheck] TEST FAILED. Arguments: (8, [255], [GfElem(1797454381), GfElem(2770396913), GfElem(998084813), GfElem(463965418), GfElem(373228609), GfElem(1448295553), GfElem(424671901), GfElem(1), GfElem(1857253999), GfElem(2454037938)])
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@cyphar
Copy link
Owner Author

cyphar commented Jul 15, 2024

Ah, so the issue is that if the secret is one byte then there is a 1-in-256 chance that we will accidentally get the same secret. I guess we could restrict the test to be >=2 bytes, but being able to test single-byte secrets is also worthwhile...

@cyphar
Copy link
Owner Author

cyphar commented Jul 15, 2024

Ah, this was issue 2 in #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant