Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression] hardening against bad root paths in 0.4.0 is too agressive #46

Closed
cyphar opened this issue Jan 15, 2025 · 4 comments · Fixed by #47
Closed

[regression] hardening against bad root paths in 0.4.0 is too agressive #46

cyphar opened this issue Jan 15, 2025 · 4 comments · Fixed by #47

Comments

@cyphar
Copy link
Owner

cyphar commented Jan 15, 2025

Requiring filepath.Clean paths means that root values with trailing /s will also error out. It might make more sense for us to just look for .. components.
This was referenced Jan 18, 2025
Merged
Merged
@kolyshkin
Copy link
Contributor

Another broken user: containers/podman#25001

@kolyshkin
Copy link
Contributor

Can we have 0.4.1 with the fix released?

@cyphar
Copy link
Owner Author

cyphar commented Jan 28, 2025

Yup, sorry my wedding is this weekend so I haven't had a chance to sit down and do the release. I'll publish it now -- #48.

@cyphar
Copy link
Owner Author

cyphar commented Jan 28, 2025

https://github.com/cyphar/filepath-securejoin/releases/tag/v0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

join: loosen cleanliness requirements for SecureJoin root cyphar/filepath-securejoin
2 participants
@cyphar @kolyshkin