Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip tests that have a different output with R 4.3, when version is > 4.2 #189

Closed
moodymudskipper opened this issue Jun 6, 2023 · 2 comments
Closed

skip tests that have a different output with R 4.3, when version is > 4.2 #189

moodymudskipper opened this issue Jun 6, 2023 · 2 comments

Comments

@moodymudskipper
Copy link
Collaborator

for #188

quick fix, we could also update to 4.3 but that will be easier to do things right later if we stay with 4.2 for now
@moodymudskipper moodymudskipper mentioned this issue Jun 6, 2023
Closed
@moodymudskipper
Copy link
Collaborator Author

tried to do it but for some reason it doesn't fix

@moodymudskipper
Copy link
Collaborator Author

moodymudskipper commented Jun 6, 2023 •
edited
Loading

dm is causing issues with pkgdown due to DiagrammeR but I don't understand why pkgdown needs to load dm, esp related to the opts_dm() fun. In any case just loading dm shouldn't require DiagrammeR

https://github.com/cynkra/constructive/actions/runs/5193051937/jobs/9363131026

Adding diagram packages to Suggests fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moodymudskipper