Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skipCRDs option to Module definition #602

Open
petar-cvit opened this issue Oct 4, 2024 · 5 comments · May be fixed by #616
Open

Add skipCRDs option to Module definition #602

petar-cvit opened this issue Oct 4, 2024 · 5 comments · May be fixed by #616
Assignees
Labels
controller Update on controller go Pull requests that update Go code good first issue Good for newcomers hacktoberfest kubernetes k8s related issues ⚔️ Quest Tracks quest-bot quests

Comments

@petar-cvit
Copy link
Collaborator

petar-cvit commented Oct 4, 2024

Each Module is deployed from a template that can be a Helm chart. Helm charts can contain a list of CRDs that need to be installed in order for the application to work or provide its capability.

However, managing CRDs through Helm is opinionated, so the scope of the issue is to disable creating CRDs defined in a template when a Module is created.

Describe the solution you'd like

The Module definition should store whether CRD creation should be skipped and taken into account in the reconciliation loop. Also, to make it easier for users, the skip CRDs option should be available in the advanced section when creating a new Module and passed to the cyclops-ctrl on Module submit.

Screenshot 2024-09-24 at 22 27 59
@petar-cvit petar-cvit added good first issue Good for newcomers go Pull requests that update Go code controller Update on controller kubernetes k8s related issues hacktoberfest labels Oct 4, 2024
@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 4, 2024
Copy link

quest-bot bot commented Oct 4, 2024

New Quest! image New Quest!

A new Quest has been launched in @cyclops-ui’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #602 to link your PR to this Quest.

Questions? Check out the docs.

@kom-senapati
Copy link
Contributor

I want to work on this @petar-cvit

@kom-senapati
Copy link
Contributor

@quest-bot embark

Copy link

quest-bot bot commented Oct 7, 2024

@kom-senapati has embarked on their Quest. 🗡

  • @kom-senapati has been on GitHub since 2021.
  • They have merged 141 public PRs in that time.
  • Their swords are blessed with JavaScript and CSS magic ✨
  • They have contributed to this repo before.

Questions? Check out the docs.

@kom-senapati kom-senapati linked a pull request Oct 7, 2024 that will close this issue
2 tasks
Copy link

quest-bot bot commented Oct 7, 2024

🧚 @kom-senapati has submitted PR #616 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller Update on controller go Pull requests that update Go code good first issue Good for newcomers hacktoberfest kubernetes k8s related issues ⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants