Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: AbstractLoader::JOIN (or LEFT_JOIN) for public use #202

Open
1 task done
gam6itko opened this issue May 20, 2024 · 0 comments
Open
1 task done

[Bug]: AbstractLoader::JOIN (or LEFT_JOIN) for public use #202

gam6itko opened this issue May 20, 2024 · 0 comments
Labels
type: feature New feature.

Comments

@gam6itko
Copy link
Contributor

No duplicates 🥲.

  • I have searched for a similar issue in our bug tracker and didn't find any solutions.

Describe the bug

I often use constructions like

$select = $this->getOrm()->getRepository(Country::class)
    ->select()
    ->with('translation', [
        'as' => 'trans',
        'method' => JoinableLoader::LEFT_JOIN, //internal
        'where' => [
            'locale_id' => 1,
        ],
]);

but the psalm generates errors

 InternalClass - App\MyClass.php:164:34 - Cycle\ORM\Select\JoinableLoader is internal to Cycle but called from App\MyClass (see https://psalm.dev/174)

Pleas make not internal constant which I use without psalm errors.

Is this a regression?

No

To Reproduce

see above

Expected behaviour

see above

Media prove

No response

Database

MySQL

Your environment

No response

Additional context

No response

@gam6itko gam6itko added the status:to be verified Needs to be reproduced and validated. label May 20, 2024
@gam6itko gam6itko changed the title [Bug]: AbstractLoader::JOIN for public use [Bug]: AbstractLoader::JOIN (or LEFT_JOIN) for public use May 20, 2024
@roxblnfk roxblnfk added type: feature New feature. and removed status:to be verified Needs to be reproduced and validated. labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature.
Projects
None yet
Development

No branches or pull requests

2 participants