Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: column type by ReflectionProperty #51

Open
wants to merge 4 commits into
base: 3.x
Choose a base branch
from

Conversation

aquaminer
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #51 (f630c7f) into 3.x (6826b61) will decrease coverage by 2.58%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.x      #51      +/-   ##
============================================
- Coverage     90.95%   88.36%   -2.59%     
- Complexity      252      262      +10     
============================================
  Files            32       32              
  Lines           619      636      +17     
============================================
- Hits            563      562       -1     
- Misses           56       74      +18     
Impacted Files Coverage Δ
src/Annotation/Column.php 100.00% <100.00%> (ø)
src/Configurator.php 85.81% <100.00%> (+0.84%) ⬆️
...Exception/AnnotationRequiredArgumentsException.php 0.00% <0.00%> (-100.00%) ⬇️
src/Entities.php 96.82% <0.00%> (-0.15%) ⬇️
src/TableInheritance.php 93.80% <0.00%> (-0.11%) ⬇️
src/Annotation/Table/PrimaryKey.php 100.00% <0.00%> (ø)
...Exception/AnnotationWrongTypeArgumentException.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6826b61...f630c7f. Read the comment docs.

@roxblnfk roxblnfk self-requested a review March 21, 2022 07:08
@roxblnfk roxblnfk added this to the 3.2.x milestone Mar 21, 2022
@roxblnfk roxblnfk removed this from the 3.2.x milestone Feb 1, 2023
@roxblnfk roxblnfk added the type:feature New feature. label Feb 1, 2023
@rustatian rustatian marked this pull request as draft September 15, 2023 08:26
@rustatian rustatian marked this pull request as ready for review September 15, 2023 08:27
@peldax
Copy link

peldax commented Jun 21, 2024

Hi,
This is great addition.

It would be nice if this functionality supported the BelongsTo/RefersTo relations as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature.
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

4 participants