Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer tests contain a circular dependency #79

Open
dustinmm80 opened this issue Sep 14, 2018 · 0 comments
Open

Installer tests contain a circular dependency #79

dustinmm80 opened this issue Sep 14, 2018 · 0 comments

Comments

@dustinmm80
Copy link
Contributor

To test install.sh, we run it in Docker containers to test that it works okay. This is fine, but creates a problem for releases. install.sh inspects the local version and tries to pull that from github releases, but when you're releasing a new version that release isn't up yet and the build fails.

Examples

We need to rethink how we run this test as part of our release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant