Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health check provides more meaningful error message #59

Open
jtuttle opened this issue Oct 9, 2018 · 2 comments
Open

Health check provides more meaningful error message #59

jtuttle opened this issue Oct 9, 2018 · 2 comments
Labels
component/service-broker kind/enhancement

Comments

@jtuttle
Copy link
Member

jtuttle commented Oct 9, 2018

In the bin/health_check.rb script we raise an error with a useful message and then rescue it and throw it away. We should make sure we are providing a useful error wherever possible.
@jtuttle jtuttle changed the title Health check provides more meaningful message Health check provides more meaningful error message Oct 9, 2018
@TheSecMaven
Copy link
Contributor

^^ This was a huge source of time waste for us in working with CyberArk to get the service broker working. Ended up being that the certificate on our host was not valid for the FQDN and thus it failed to validate the cert. Error checking is needed so that this can more easily be resolved, it just said "Error: There is an issue with your Conjur configuration. Please verify"
" that the credentials are correct and try again" and that is not as helpful as it could be 👍

@TheSecMaven
Copy link
Contributor

We recently did another deploy of this and again the error message caused us great headaches. It should check whether an ASG is causing an issue. By default our ASGs were causing the app to break. the error implied we had configured something wrong in conjur but in fact it was simply unable to connect to conjur.

@izgeri izgeri modified the milestones: There is an updated release of the TAS tile - Milestone 1, There is an updated release of the TAS tile - Milestone 2 Jul 9, 2020
@izgeri izgeri removed this from the There is an updated release of the TAS tile - Milestone 2 milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/service-broker kind/enhancement
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheSecMaven @jtuttle @izgeri