Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract response function into a util #186

Closed
1 of 2 tasks
orenbm opened this issue Nov 1, 2020 · 1 comment · Fixed by #187
Closed
1 of 2 tasks

Extract response function into a util #186

orenbm opened this issue Nov 1, 2020 · 1 comment · Fixed by #187
Labels
component/k8s kind/enhancement

Comments

@orenbm
Copy link
Member

orenbm commented Nov 1, 2020 •
edited
Loading

We have some methods in the authenticator package that handle HTTP
responses. We can benefit from extracting them into utils with code
clarity.

DoD:

  • The methods readBody & validateResponse are extracted into a util
  • These methods have UTs
@orenbm orenbm mentioned this issue Nov 1, 2020
Merged
3 tasks
@orenbm
Copy link
Member Author

orenbm commented Nov 1, 2020

Created an issue for adding UTs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/k8s kind/enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract response utils cyberark/conjur-authn-k8s-client
1 participant
@orenbm