You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We recently added utility functions to extract values from environment variables. We should consider adding input validations on the given values so that the application doesn't work unexpectedly. For example, what happens if the user set CONJUR_CLIENT_CERT_RETRY_COUNT_LIMIT to -2? Do we want to limit this env var to have a minimum of 0? do we want another minimum?
We should consider to implement this in a way that the util will get a new struct EnvironmentVariable that can have fields for name, defaultValue, minValue, maxValue (and maybe other fields?).
Other questions that need to be addressed while implementing this are:
what is the minimum value of CONJUR_TOKEN_TIMEOUT?
what is the minimum value of CONJUR_CLIENT_CERT_RETRY_COUNT_LIMIT?
Do the above have a maximum value?
what do we do in case the given value is less than the minimum? Do we fail the app or use the default value?
does the answer to the previous question changes how we handle cases where the user gave an invalid value for CONJUR_TOKEN_TIMEOUT?
We should also have backwards-compatibility in mind.
DoD:
Utils are updated to have also a min (and max?) value
The text was updated successfully, but these errors were encountered:
We recently added utility functions to extract values from environment variables. We should consider adding input validations on the given values so that the application doesn't work unexpectedly. For example, what happens if the user set
CONJUR_CLIENT_CERT_RETRY_COUNT_LIMIT
to-2
? Do we want to limit this env var to have a minimum of 0? do we want another minimum?We should consider to implement this in a way that the util will get a new struct
EnvironmentVariable
that can have fields forname
,defaultValue
,minValue
,maxValue
(and maybe other fields?).Other questions that need to be addressed while implementing this are:
CONJUR_TOKEN_TIMEOUT
?CONJUR_CLIENT_CERT_RETRY_COUNT_LIMIT
?CONJUR_TOKEN_TIMEOUT
?We should also have backwards-compatibility in mind.
DoD:
The text was updated successfully, but these errors were encountered: