Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce tag-less global flag usage #85

Open
Zankoas opened this issue Jan 30, 2020 · 0 comments
Open

Enforce tag-less global flag usage #85

Zankoas opened this issue Jan 30, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Zankoas
Copy link
Contributor

Zankoas commented Jan 30, 2020 •
edited
Loading

Global flags are global, surprise surprise, so use of scopes around them is pointless.

JAP = { has_global_flag = JAP_Fading_Sun }
is the same as
has_global_flag = JAP_Fading_Sun

Thus for neatness, an info should be shown saying that isn't needed. Same for setting global flags.
@Zankoas Zankoas added the enhancement New feature or request label Jan 30, 2020
@Zankoas Zankoas added the good first issue Good for newcomers label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Zankoas