Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop function doesn't work right #535

Open
jonsnow231 opened this issue Jun 17, 2024 · 6 comments
Open

Crop function doesn't work right #535

jonsnow231 opened this issue Jun 17, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@jonsnow231
Copy link

This app worked fine for me for a long time. I stopped using the crop feature months ago because it would output an image that was below what I cropped it at. I'm talking about when I set subsequent action to crop. It doesn't matter if I do legacy/screenshot or whatever to actually take it. Because it works fine if I have it open in a different editor other than Screenshot Tile to crop right aftewards.

But that was the entire reason I started using Screenshot Tile, because I could immediately crop it and have that saved, no extra steps.

I'm using Graphene OS if that makes a difference. I tried deleting storage/cache, fresh install from both F-Droid and Play Store, and all have the same problem where crop outputs below what you actually crop it as.

Also, why is the app 3.6mb in F-Droid, and 2.2mb or so in Google Play?

@cvzi
Copy link
Owner

cvzi commented Jun 17, 2024

Thanks, I'll look into.

Regarding the app size, I have no idea. I just upload the apk files from F-Droid to Google Play (and also here on Github in the releases) and as far as I understand Google doesn't alter the apk file.

@cvzi cvzi added the bug Something isn't working label Jun 17, 2024
@cvzi cvzi self-assigned this Jun 17, 2024
@cvzi
Copy link
Owner

cvzi commented Jun 19, 2024

@jonsnow231 Which Android version do you use?

I can reproduce this on Android 14 on the emulator. Likely this is related to #462 where the screen coordinates were also different on Android 14 compared to older Android.

cvzi added a commit that referenced this issue Jun 19, 2024
@cvzi
Copy link
Owner

cvzi commented Jun 22, 2024

A new version is now available that probably fixes this problem.

@jonsnow231
Copy link
Author

A new version is now available that probably fixes this problem.

I tested it out, and it works now if you take a screenshot and have subsequent option crop it. This seems fine for me, but just so you know, the same problem persists if you have the assist action be select area and subsequent action do nothing. Then the crop from selecting an area goes below whatever you selected.

@cvzi
Copy link
Owner

cvzi commented Jun 29, 2024

Thanks!
Should be fixed now in the assist action as well

@Kreiri
Copy link

Kreiri commented Sep 9, 2024

I have this issue with 2.11.2 on Android 13 (Moto G54 5G). Actual cropped images appear to be lower than the intended cropped area by the height of the status bar. (Tested by selecting top area of the screen, status bar included, in the crop tool.)

@cvzi cvzi reopened this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants