Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the origin from the document's URL if the name manifest key cannot be generated when creating a synthetic fall-back manifest #25

Open
cvan opened this issue Apr 13, 2017 · 0 comments

Comments

@cvan
Copy link
Owner

cvan commented Apr 13, 2017

When creating a fall-back synthetic manifest (from issue #3), it's possible that the app name cannot be generated if none of the following exist and contain a non-empty value:

meta[name="apple-mobile-web-app-title"],
meta[name="application-name"],
meta[property="og:site_name"],
meta[property="og:title"],
meta[property="twitter:app_name"],
meta[property="twitter:site_name"],
meta[name="twitter:title"],
title

In this case, generate a name based on the origin (e.g., abc.example.com) of the document URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant