Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy concepts table "data-cy=..." selectors #1513

Open
kmdvs opened this issue Dec 16, 2024 · 6 comments · May be fixed by #1523
Open

Taxonomy concepts table "data-cy=..." selectors #1513

kmdvs opened this issue Dec 16, 2024 · 6 comments · May be fixed by #1523
Assignees
Milestone

Comments

@kmdvs
Copy link
Collaborator

kmdvs commented Dec 16, 2024

In Taxonomy's concept table, the "data-cy-..." need to have those characteristics:

  • Unique throughout Taxonomy
  • independent on cell data
  • Unchanging throughout UX changes, except if that UI code is deleted
  • Ideally able to address each element separately in order to help make RT comprehensive and robust

Right now, data-cy selectors are dependent on cell content. That dependency makes RT complex, more inefficient and more brittle.

@kmdvs
Copy link
Collaborator Author

kmdvs commented Dec 16, 2024

Already talked with Syam, who confirmed the issue. Waiting to be scheduled. This is needed for RT synchronization to latest Taxonomy page.

@troughc
Copy link
Contributor

troughc commented Dec 17, 2024

@kmdvs @SyamBabu-M what is the urgency level? I need this to set a priority.
cc @SuhailAliyar
thanks!

@troughc troughc added the estimate needed Add estimate for planning label Dec 17, 2024
@kmdvs
Copy link
Collaborator Author

kmdvs commented Dec 17, 2024

@troughc @SyamBabu-M RT will give an error until a fix is done.

@troughc troughc removed their assignment Dec 18, 2024
@troughc troughc removed the estimate needed Add estimate for planning label Dec 18, 2024
@troughc troughc added this to the CC 2024.3 milestone Dec 19, 2024
@SyamBabu-M SyamBabu-M linked a pull request Jan 3, 2025 that will close this issue
@kmdvs
Copy link
Collaborator Author

kmdvs commented Jan 8, 2025

@SyamBabu-M The data-cy still seem dependent on locale... Like
data-cy="taxonomy-concept-cellConceptAnglais"
data-cy="taxonomy-concept-cellConceptEnglish"

That should be changed to a unique, non-dependent on locale or anything else... Best would be in this case
data-cy="taxonomy-concept-cellConceptEnglish" for anly locale

@SyamBabu-M
Copy link
Contributor

@kmdvs I have removed the dependency of data-cy on content-languages, concept names, and locales.
Please let me know if any other changes are needed.

@kmdvs
Copy link
Collaborator Author

kmdvs commented Jan 8, 2025

@SyamBabu-M
OK, but it still needs to be unique, per language...
So instead of
data-cy="taxonomy-concept-cell"
it should have a unique signature, using the language it refers to... But that should not be dependent on user locale

So this is OK

  1. For the English cell
    data-cy="taxonomy-concept-cell-English" for all locale
  2. For the French cell
    data-cy="taxonomy-concept-cell-French" for all locale
    etc.

but this is not

  1. For the English cell
    data-cy="taxonomy-concept-cell-English" for en locale
    data-cy="taxonomy-concept-cell-Anglais" for fr locale
    and so on

@kmdvs kmdvs assigned SyamBabu-M and unassigned kmdvs Jan 8, 2025
@sahalali sahalali modified the milestones: CC 2024.3, CC 2025.1 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants