Fixes key-value storage interface

Author: cuducos

transform/company_test.go

@@ -117,7 +117,7 @@ func TestNewCompany(t *testing.T) {
 		if err != nil {
 			t.Errorf("expected no error creating badger, got %s", err)
 		}
-		defer kv.close()
+		defer kv.close(false)
 		lookups, err := newLookups(testdata)
 		if err != nil {
 			t.Errorf("expected no errors creating look up tables, got %v", err)
@@ -273,7 +273,7 @@ func TestNewCompany(t *testing.T) {
 		if err != nil {
 			t.Errorf("expected no error creating badger, got %s", err)
 		}
-		defer kv.close()
+		defer kv.close(false)
 		lookups, err := newLookups(testdata)
 		if err != nil {
 			t.Errorf("expected no errors creating look up tables, got %v", err)

transform/kv.go

@@ -164,7 +164,7 @@ func (kv *badgerStorage) enrichCompany(c *company) error {
 
 func (b *badgerStorage) close(k bool) error {
 	b.db.Close()
-	if !k && b.path != ""  {
+	if !k {
 		if err := os.RemoveAll(b.path); err != nil {
 			return fmt.Errorf("error cleaning up badger storage directory: %w", err)
 		}

transform/kv_test.go

@@ -19,7 +19,7 @@ func TestBadgerStorageClose(t *testing.T) {
 	if err != nil {
 		t.Errorf("expected no error creating badger storage, got %s", err)
 	}
-	if err := kv.close(); err != nil {
+	if err := kv.close(false); err != nil {
 		t.Errorf("expected no error closing badger storage, got %s", err)
 	}
 	if _, err := os.Stat(kv.path); err == nil || !os.IsNotExist(err) {
@@ -74,7 +74,7 @@ func TestLoad(t *testing.T) {
 	if err != nil {
 		t.Fatalf("could not create badger storage: %s", err)
 	}
-	defer kv.close()
+	defer kv.close(false)
 	if err := kv.load(testdata, &l); err != nil {
 		t.Errorf("expected no error loading data, got %s", err)
 	}
@@ -103,7 +103,7 @@ func TestEnrichCompany(t *testing.T) {
 	if err != nil {
 		t.Fatalf("could not create badger storage: %s", err)
 	}
-	defer kv.close()
+	defer kv.close(false)
 	if err := kv.load(testdata, &l); err != nil {
 		t.Errorf("expected no error loading data, got %s", err)
 	}

transform/transform.go

@@ -33,7 +33,7 @@ type database interface {
 type kvStorage interface {
 	load(string, *lookups) error
 	enrichCompany(*company) error
-	close() error
+	close(bool) error
 }
 
 type mode int

transform/venues_test.go

@@ -18,7 +18,7 @@ func TestTaskRun(t *testing.T) {
 	if err != nil {
 		t.Errorf("expected no error creating badger, got %s", err)
 	}
-	defer kv.close()
+	defer kv.close(false)
 	lookups, err := newLookups(testdata)
 	if err != nil {
 		t.Errorf("expected no errors creating look up tables, got %v", err)