Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutOfRangeError if test set larger than dev set #14

Open
kldtz opened this issue Aug 1, 2018 · 0 comments
Open

OutOfRangeError if test set larger than dev set #14

kldtz opened this issue Aug 1, 2018 · 0 comments

Comments

@kldtz
Copy link

kldtz commented Aug 1, 2018

There is a little issue in cs230-code-examples/tensorflow/nlp/evaluate.py: You use the dev set for evaluation:

path_eval_sentences = os.path.join(args.data_dir, 'dev/sentences.txt')
path_eval_labels = os.path.join(args.data_dir, 'dev/labels.txt')

But later you iterate over the size of the test set:

params.eval_size = params.test_size

If the test set is larger than the dev set, this leads to an OutOfRangeError. If the test set is smaller than the dev set, the iteration stops too early.

Thanks for sharing the code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant