Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails when code that throws an error is marked as crystal-play #613

Open
ftarulla opened this issue May 26, 2022 · 1 comment
Open

CI fails when code that throws an error is marked as crystal-play #613

ftarulla opened this issue May 26, 2022 · 1 comment

Comments

@ftarulla
Copy link
Contributor

The CI will compile code-blocks marked with crystal-play.
So when the code-block itself is an example of a compile error (ie. it is suppose to throw an error) then the CI fails.

Example:

def life_universe_and_everything
  "Fortytwo"
end

puts life_universe_and_everything + 1 # Error: no overload matches 'String#+' with type Int32

This code block shows an example of a compile error. And therefore it is supposed to fail when compiled. As expected, when compiled by the CI, it fails.

Maybe we can mark these blocks of code in some way that the CI skips them 🤔

@straight-shoota
Copy link
Member

I suppose we could scan for # Error: in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants