Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we have a reliable embedded TLS client backed by libcrux for the demo #15

Open
2 tasks
keks opened this issue Sep 27, 2024 · 0 comments
Open
2 tasks

Comments

@keks
Copy link
Member

keks commented Sep 27, 2024

Work has started on a libcrux provider for Rustls: https://github.com/cryspen/rustls/tree/keks/libcrux-provider

While Rustls, when using our provider, can fetch a small file off github, it runs into various error conditions on most websites (e.g. google.com). However, it's not entirely clear if this is a bug in Rustls or in our provider; When running the test client backed by the example provider, it also failed to GET google.com - but with a different error. I think the current options are:

  • The example provider is doing something wrong and we copied it
  • We are doing something wrong with an error of our own making
  • Rustls is doing something wrong

One more thing: I changed the provider tests to also include libcrux, and that makes it run the HPKE tests between all permutations of pairs of implementations, and we fail one of these permutations, one of the implementations can't decrypt our ciphertext, but the other can. I doubt that it is related to the above though, because that likely doesn't even use HPKE. Also, this might also be an issue in the other implementation.

Some other info so we can quickly start working on this again:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant