Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include languageId in TranslationCostSchema interface #281

Closed
minimalsm opened this issue Jun 30, 2023 · 1 comment · Fixed by #282
Closed

Include languageId in TranslationCostSchema interface #281

minimalsm opened this issue Jun 30, 2023 · 1 comment · Fixed by #282

Comments

@minimalsm
Copy link
Contributor

Hey :) Firstly, thanks for working on this project. It's been very helpful to me 🙏

As I'm converting my code to TypeScript, I noticed one bug (?):

The TranslationCostSchema interface does not include a languageId property in it's schema, but the generate report API docs include this (and it works, as it is actually essential for our use-case 😬).

Screenshot 2023-07-01 at 18 48 15

I will open a PR to (hopefully) fix this 🫡
@andrii-bodnar andrii-bodnar linked a pull request Jun 30, 2023 that will close this issue
fix: add languageId to TranslationCostSchema interface [Fixes #281] #282
Merged
@andrii-bodnar
Copy link
Member

@minimalsm already available in the 1.23.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add languageId to TranslationCostSchema interface [Fixes #281] minimalsm/crowdin-api-client-js
2 participants
@andrii-bodnar @minimalsm