-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update module/project to crossplane-contrib/provider-upjet-github #103
Conversation
…github Signed-off-by: Jared Watts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Awesome @AtzeDeVries this PR is passing all checks! I've created the new repo on |
That looks successful! CI action https://github.com/crossplane-contrib/provider-upjet-github/actions/runs/11230655205 ran and published
Provider is installed and healthy:
CRDs are available in the control plane as well:
I think a switch needs to be flipped in the |
Awesome! |
The provider repo has been set to public in @AtzeDeVries feel free to cut the next release at your leisure. If there are any issues with it showing up on https://marketplace.upbound.io/providers/crossplane-contrib/provider-upjet-github after a release, please let me know! That link will be a 404 until a release is completed, then it should work. Also @AtzeDeVries you are admin on this repo, so please add other maintainers and give them permissions if there were any others not yet captured in https://github.com/crossplane-contrib/provider-upjet-github/blob/main/OWNERS.md. Let me know if I can be of any further help 🙇♂️ |
Description of your changes
This repository has been generously contributed from its previous source location in
coopnorge/provider-github
to this new home incrossplane-contrib/provider-upjet-github
. Thank you @AtzeDeVries and team for the awesome work on this provider and the willingness to share it even more openly with the Crossplane community!See crossplane/crossplane#5435 for background context.
This PR updates all of the project module/import/build paths to point to this new source location. This could be a breaking change if other projects outside of this repo were importing them directly for source code usage in their repos, but I doubt that was being done. We took a similar approach recently with crossplane-contrib/provider-upjet-mysql#9.
Note that the CRD API groups aren't updated in this PR, so when folks already using this provider upgrade to the new published location under
crossplane-contrib
, they shouldn't be impacted at all.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
We will be relying heavily on a successful CI run of unit tests and end to end tests for this provider. Let me know if there's other additional testing we should perform.