upbound aws provider fails to create/delete SNS topic on china due to bad aws partition (shall be aws-cn and not aws)

[yebolenko]

What happened?

How can we reproduce it?

What environment did it happen in?

• Crossplane Version: docker.io/crossplane/crossplane:v1.13.2
• Provider Version: xpkg.upbound.io/upbound/provider-aws:v0.38.0
• Kubernetes Version: 1.27
• Kubernetes Distribution: EKS

[yebolenko]

Please ensure that all upbound components use aws partition as a parameter and not hardcoded aws

[yebolenko]

it seems that some info in the issue has not been update:
I'm summarizing it again:
We are trying to create/delete SNS Topic with crossplane/upbound on aws China region cn-north-1
When SNS topic shall be created/deleted, it fails with the following error:
InvalidParameter: Invalid parameter: TopicArn Reason: A REDACTED ARN must begin with arn:aws-cn, not arn:aws:sns:REDACTED:REDACTED:ye-sns-topic-2-demo-china-cnn1\n\tstatus code: 40I

[yebolenko]

any progress?

[turkenf]

@yebolenko, could you please fill in the description properly? Reproduction steps, the MRs you used, expected and actual behavior.

[yebolenko]

It's always reproducible. You just need to create/delete SNS topic on aws region cn-north-1 (china).
It doesn't work due to hardcoded aws partition id (aws) and not aws-cn.
I believe it's general issue also in many other resources. You need to add ability to pass aws partition id as parameter (aws is default)

[yebolenko]

any update? it's URGENT issue for us. We cannot use SNS and (maybe other components) on china.
As I said, we use an official upbound release

[turkenf]

Please provide the requested information in the description.

[yebolenko]

Providing again all details:

What happened? When SNS topic shall be created/deleted, it fails with the following error:
InvalidParameter: Invalid parameter: TopicArn Reason: A REDACTED ARN must begin with arn:aws-cn, not arn:aws:sns:REDACTED:REDACTED:ye-sns-topic-2-demo-china-cnn1\n\tstatus code: 40I
How can we reproduce it? It's always reproducible. You just need to create/delete SNS topic on aws region cn-north-1 (china).
What environment did it happen in?
Crossplane Version: docker.io/crossplane/crossplane:v1.13.2
Provider Version: xpkg.upbound.io/upbound/provider-aws:v0.38.0
Kubernetes Version: 1.27
Kubernetes Distribution: EKS
Notes:
It doesn't work due to hardcoded aws partition id (aws) and not aws-cn.
I believe it's general issue also in many other resources. You need to add ability to pass aws partition id as parameter (aws is default)

[yebolenko]

As I said above, it seems that we already have similar issue (with the same root cause, that hardcoded aws partition is used) for GOV
#757

[turkenf]

Hi @yebolenko,

Thank you for raising this issue, it can be reproducible with the following MR:

apiVersion: sns.aws.upbound.io/v1beta1
kind: Topic
metadata:
  name: example
  labels:
    testing.upbound.io/example-name: sns
spec:
  forProvider:
    region: cn-north-1

This issue will be sorted and handled according to the prioritization policy.

[yebolenko]

Fatih, thank you. Please let me know when it will be resolved. As I said, it's not only SNS. It's a general issue with hardcoded aws partition Id (aws:) and I believe that some global fix is required (which will fix in general special regions such as China and AWS GOV)

[github-actions]

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

[github-actions]

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

[github-actions]

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!

[cnshadzh]

The issue still exists, failed to create sns topic in region cn-northwest-1 with the same error.