-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: LaunchTemplateVersions are being created with zero changes to the actual spec #1525
Comments
Was thinking about this..and I suspect this may be happening because I've only imported a launch template, but I didn't specify a corresponding |
Ach couldn't wait to try this. So turns out one can't import the latest version into a MR(no field for that) so I added While I'd def like to help document this - I understand every MR has some idiosyncrasy or the other and I'm not sure what trying to document all these scenarios would like. In any case, this bug report - since it's no longer a bug - can be closed. |
Actually there is an interesting side effect. To import a launch template and not have the versions go haywire, I need to import the default version in. I'd also like to ensure that if I subsequently make changes to the launch template, the default version's also updated - which is what |
Sorry for the spam - trying to get to the bottom of this because I wish to import some live production clusters using these launch templates and I'd hate to foul things up. As noted in the previous comment - per the provider docs Here's the updated
|
Is there an existing issue for this?
Affected Resource(s)
ec2.aws.upbound.io/v1beta1 - LaunchTemplate
Resource MRs required to reproduce the bug
Steps to Reproduce
LaunchTemplate
/ import an existing one into Crossplane. After doing so, make no changes.LaunchTemplate
.You'll see the versions increment every minute or so.
What happened?
Apparently the provider ends up running a reconciliation loop(I've used Cluster API a lot so pardon the parlance) where it will create a fresh
LaunchTemplateVersion
even if the originalLaunchTemplate
on Crossplane hasn't been modified. This is fairly unexpected behaviour, since the whole idea behind versioning is to have some semblance of change across every version. Versions with no changes between them make it a lot more harder to track what actually may have changed. In addition, fairly certain AWS was going to either throw a429
at some point / blacklist my credentials thinking I'm a malicious actor.Relevant Error Output Snippet
Crossplane Version
1.17.1-up.1
Provider Version
1.15.0
Kubernetes Version
1.31
Kubernetes Distribution
Kind
Additional Info
Related issue - #105
The text was updated successfully, but these errors were encountered: