Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty TypeMeta while running API conversions #1422

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix empty TypeMeta while running API conversions #1422

wants to merge 2 commits into from

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Jul 25, 2024 •
edited
Loading

Description of your changes

Depends on: crossplane/upjet#424

To be completed... cc. @mergenci, @turkenf

  • Fix an issue with API conversions when the TypeMeta information has been dropped.
  • Add v1beta1 -> v1beta3 field renaming conversions for relevant resources.
  • Do not replace but append conversion functions.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested against crossplane-contrib/provider-upjet-aws resource Instance.rds with conversions between the versions v1beta1 & v1beta2.

@ulucinar
Bump upjet to commit e489efa71796
d6aea27 
- Fix an issue with API conversions when the TypeMeta information
  has been dropped.
- Add v1beta1 -> v1beta3 field renaming conversions for relevant
  resources.
- Do not replace but append conversion functions.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar ulucinar marked this pull request as draft July 25, 2024 11:12
@ulucinar
Copy link
Collaborator Author

Hi @turkenf, @mergenci,
Could you please take over this? Please ping me if help is needed.

@github-actions GitHub Actions
Copy link

This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Oct 24, 2024
@turkenf
Copy link
Collaborator

turkenf commented Oct 24, 2024

/fresh

@github-actions github-actions bot removed the stale label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

@turkenf turkenf Awaiting requested review from turkenf turkenf is a code owner

@mbbush mbbush Awaiting requested review from mbbush mbbush is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulucinar @turkenf @jeanduplessis