Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emr_cluster, emr_instance_fleet, emr_instance_group #1416

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

sanhaKimVics
Copy link
Contributor

@sanhaKimVics sanhaKimVics commented Jul 24, 2024

Adding emr_cluster, emr_instance_fleet, emr_instance_group resource.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Manually tested

  1. emr_cluster
cluster 2. emr_instance_fleet, emr_instance_group instance fleet instance group instance fleet, group

Current issue with emr_cluster

While I was doing uptest e2e test with the cluster example, I faced this error after successful creation.

 logger.go:42: 16:20:42 | case/0-apply |       message: 'observe failed: cannot convert the singleton lists in the observed
    logger.go:42: 16:20:42 | case/0-apply |         state value map into embedded objects: failed to convert between Crossplane
    logger.go:42: 16:20:42 | case/0-apply |         and Terraform layers in mode "fromTerraform": cannot expand wildcards for
    logger.go:42: 16:20:42 | case/0-apply |         the field path expression master_instance_fleet[*].launch_specifications:
    logger.go:42: 16:20:42 | case/0-apply |         cannot expand wildcards for segments: "master_instance_fleet[*].launch_specifications":
    logger.go:42: 16:20:42 | case/0-apply |         wildcard field "master_instance_fleet" is not found in the path

@jeanduplessis
Copy link
Collaborator

/test-examples="examples/emr/v1beta1/cluster.yaml,examples/emr/v1beta1/instancefleet.yaml,examples/emr/v1beta1/instancegroup.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jul 25, 2024

Many thanks, @sanhaKimVics 🙌 I will take a look at in detail next week.

@turkenf
Copy link
Collaborator

turkenf commented Jul 25, 2024

/test-examples="examples/emr/v1beta1/instancefleet.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jul 25, 2024

/test-examples="examples/emr/v1beta1/instancegroup.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your efforts @sanhaKimVics, I left some initial comments for you to consider.

config/emr/config.go Outdated Show resolved Hide resolved
config/emr/config.go Outdated Show resolved Hide resolved
config/emr/config.go Outdated Show resolved Hide resolved
examples/emr/v1beta1/cluster.yaml Outdated Show resolved Hide resolved
examples/emr/v1beta1/cluster.yaml Outdated Show resolved Hide resolved
examples/emr/v1beta1/cluster.yaml Show resolved Hide resolved
examples/emr/v1beta1/instancefleet.yaml Outdated Show resolved Hide resolved
examples/emr/v1beta1/instancefleet.yaml Show resolved Hide resolved
@sanhaKimVics
Copy link
Contributor Author

sanhaKimVics commented Sep 5, 2024

Screenshot 2024-09-05 at 11 06 31 PM Screenshot 2024-09-05 at 10 47 44 PM
 logger.go:42: 16:20:42 | case/0-apply |       message: 'observe failed: cannot convert the singleton lists in the observed
    logger.go:42: 16:20:42 | case/0-apply |         state value map into embedded objects: failed to convert between Crossplane
    logger.go:42: 16:20:42 | case/0-apply |         and Terraform layers in mode "fromTerraform": cannot expand wildcards for
    logger.go:42: 16:20:42 | case/0-apply |         the field path expression master_instance_fleet[*].launch_specifications:
    logger.go:42: 16:20:42 | case/0-apply |         cannot expand wildcards for segments: "master_instance_fleet[*].launch_specifications":
    logger.go:42: 16:20:42 | case/0-apply |         wildcard field "master_instance_fleet" is not found in the path

@turkenf
After successfully creating the cluster with Uptest, I kept getting the same error as before, so I couldn't pass the local automated test.

Any help to resolve this would be appreciated.

@sanhaKimVics
Copy link
Contributor Author

/test-examples="examples/emr/v1beta1/cluster.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Oct 24, 2024

Hi @sanhaKimVics, thank you for your patience here. Are you still interested in moving this PR forward? If so, please rebase your PR to the main, run make generate, and test the resources again. If you still get errors please let us know.

@sanhaKimVics
Copy link
Contributor Author

Hi @sanhaKimVics, thank you for your patience here. Are you still interested in moving this PR forward? If so, please rebase your PR to the main, run make generate, and test the resources again. If you still get errors please let us know.

Sure I'll rebase and do the test again thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants