Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support authentication plugins like ldap simple #133

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

alereca
Copy link
Contributor

@alereca alereca commented Mar 6, 2023

Description of your changes

Fixes #125

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Added unit test for user controller create and update methods

  • UserWithAnAuthPluginThatNotRequiresPassword (for both)

@alereca alereca force-pushed the feat/support-authentication-plugins-like-ldap-simple branch from 31c0af7 to 6529b9e Compare March 6, 2023 20:11
@Duologic
Copy link
Member

Would you mind rebasing?

@mcanevet
Copy link

@alereca are you still interested in this feature? I'd like to see this merged, I can rebase and open a new PR crediting your work if you want.

@alereca
Copy link
Contributor Author

alereca commented Jun 28, 2024

@alereca are you still interested in this feature? I'd like to see this merged, I can rebase and open a new PR crediting your work if you want.

@mcanevet I would greatly appreciate it. Currently, I'm quite busy working on some quarterly job tasks and finishing my studies. Please let me know if you have any questions about anything here.

@alereca
Copy link
Contributor Author

alereca commented Jun 28, 2024

Would you mind rebasing?

@Duologic Sorry I didn't answer before

@mcanevet
Copy link

mcanevet commented Jul 1, 2024

@alereca I think I underestimated the complexity of the conflicts.
I'm not sure how to fix the one on reconciler.go: https://gist.github.com/mcanevet/24b2fde49eab35c4ed717a4ebb5badf2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Authentication Plugins like authentication_ldap_simple
3 participants