Feat/support authentication plugins like ldap simple #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es it Signed-off-by: Alejandro Recalde <[email protected]>
…revious behavior working Signed-off-by: Alejandro Recalde <[email protected]>
Signed-off-by: Alejandro Recalde <[email protected]>
Signed-off-by: Alejandro Recalde <[email protected]>
Signed-off-by: Alejandro Recalde <[email protected]>
…ser spec field diverged Signed-off-by: Alejandro Recalde <[email protected]>
Signed-off-by: Alejandro Recalde <[email protected]>
Signed-off-by: Alejandro Recalde <[email protected]>
alereca
force-pushed
the
feat/support-authentication-plugins-like-ldap-simple
branch
from
31c0af7
to
6529b9e
Compare
|
Would you mind rebasing? |
|
@alereca are you still interested in this feature? I'd like to see this merged, I can rebase and open a new PR crediting your work if you want. |
@mcanevet I would greatly appreciate it. Currently, I'm quite busy working on some quarterly job tasks and finishing my studies. Please let me know if you have any questions about anything here. |
@Duologic Sorry I didn't answer before |
|
@alereca I think I underestimated the complexity of the conflicts. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #125
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Added unit test for user controller create and update methods