Skip to content

Commit f01d533

Browse files
Apply suggestions from code review
Co-authored-by: Philippe Scorsolini <[email protected]> Signed-off-by: Steven Borrelli <[email protected]>
1 parent ed7d8f4 commit f01d533

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,8 @@ apiVersion: meta.gotemplating.fn.crossplane.io/v1alpha1
193193
kind: Context
194194
data:
195195
"apiextensions.crossplane.io/environment":
196+
kind: Environment
197+
apiVersion: internal.crossplane.io/v1alpha1
196198
update: environment
197199
nestedEnvUpdate:
198200
hello: world

example/context/README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,17 +47,13 @@ fields:
4747
hello: world
4848
update: environment
4949
newkey:
50-
apiVersion: internal.crossplane.io/v1alpha1
5150
hello: world
52-
kind: Environment
5351
other-context-key:
54-
apiVersion: internal.crossplane.io/v1alpha1
5552
complex:
5653
a: b
5754
c:
5855
d: e
5956
f: "1"
60-
kind: Environment
6157
kind: Context
6258
```
6359

example/context/composition.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ spec:
3434
data:
3535
# update existing EnvironmentConfig by using the "apiextensions.crossplane.io/environment" key
3636
"apiextensions.crossplane.io/environment":
37-
kind: Environment,
38-
apiVersion: internal.crossplane.io/v1alpha1,
37+
kind: Environment
38+
apiVersion: internal.crossplane.io/v1alpha1
3939
update: environment
4040
nestedEnvUpdate:
4141
hello: world

0 commit comments

Comments
 (0)