Issue22 #27
Merged
Issue22 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #22, while also making some changes to BE-related functionality:
txTable()andexonTable(), respectively) that are consistent with other accessor functionseditedAlleles()accessor to make it consistent with other accessor functions (returns single table ifunlist=TRUE)This branch passes
check, but we should ensure that changes toeditedAlleles()will not break anything dependent on it before merge.Follow up question: should
crisprBase::getProtospacerRanges(the cause of the error when passing GuideSets with NTCs toGuideSet2DataFrames) handle input with NTCs? If not, it should return a more helpful error message. I can setup and manage this issue in crisprBase.