Say something after "You have ." when wielding a non-weapon item (fix #4172) #4179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-weapon items are single-handed so single form is probably better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
describe_to_hit()returns immediately if the item in hand is not a weapon, resulting in printing "You have ." in the monster desc page. These commits attempts to solve that by telling the player they're not wielding a valid weapon. Also wielding a non-weapon item should be undesirable so an exclamation mark is used instead of a period.Should resolve #4172.
Didn't talk about this in the irc chatroom although the guide told me to do so because my IP is blocked (idk why). Hope it fixes the issue well and does not violate any conventions. (12/25: sry for the merge commit)