Skip to content

Commit aec87a4

Browse files
committed
CRASH-193 : Shade jline into shell module
1 parent 4a5e901 commit aec87a4

File tree

9 files changed

+10
-37
lines changed

9 files changed

+10
-37
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@ nul
1212
org.eclipse.m2e.core.prefs
1313
org.eclipse.core.resources.prefs
1414
org.eclipse.jdt.core.prefs
15+
dependency-reduced-pom.xml

connectors/ssh/pom.xml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@
1919
<groupId>org.crashub</groupId>
2020
<artifactId>crash.shell</artifactId>
2121
</dependency>
22-
<dependency>
23-
<groupId>jline</groupId>
24-
<artifactId>jline</artifactId>
25-
</dependency>
2622

2723
<!-- SSHD connector dependencies -->
2824
<dependency>
@@ -86,12 +82,6 @@
8682
<profiles>
8783
<profile>
8884
<id>main</id>
89-
<dependencies>
90-
<dependency>
91-
<groupId>jline</groupId>
92-
<artifactId>jline</artifactId>
93-
</dependency>
94-
</dependencies>
9585
<build>
9686
<pluginManagement>
9787
<plugins>

connectors/ssh/src/main/java/org/crsh/ssh/term/CRaSHCommand.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
*/
1919
package org.crsh.ssh.term;
2020

21-
import jline.Terminal;
22-
import jline.console.ConsoleReader;
21+
import org.crsh.console.jline.Terminal;
22+
import org.crsh.console.jline.console.ConsoleReader;
2323
import org.apache.sshd.server.Environment;
2424
import org.crsh.console.jline.JLineProcessor;
2525
import org.crsh.shell.Shell;

connectors/telnet/pom.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,6 @@
9898
</build>
9999

100100
<profiles>
101-
<profile>
102-
<id>main</id>
103-
<dependencies>
104-
<dependency>
105-
<groupId>jline</groupId>
106-
<artifactId>jline</artifactId>
107-
</dependency>
108-
</dependencies>
109-
</profile>
110101
<profile>
111102
<id>no-network</id>
112103
<build>

doc/api/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
</goals>
7979
<configuration>
8080
<includes>org/**/*.java</includes>
81+
<excludes>org/crsh/console/jline/**</excludes>
8182
<outputDirectory>${project.build.directory}/sources</outputDirectory>
8283
</configuration>
8384
</execution>

packaging/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@
2929
<groupId>org.crashub</groupId>
3030
<artifactId>crash.shell</artifactId>
3131
</dependency>
32-
<dependency>
33-
<groupId>jline</groupId>
34-
<artifactId>jline</artifactId>
35-
</dependency>
3632
<dependency>
3733
<groupId>org.codehaus.groovy</groupId>
3834
<artifactId>groovy-all</artifactId>

plugins/cron/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,6 @@
5959
<profiles>
6060
<profile>
6161
<id>main</id>
62-
<dependencies>
63-
<dependency>
64-
<groupId>jline</groupId>
65-
<artifactId>jline</artifactId>
66-
</dependency>
67-
</dependencies>
6862
<build>
6963
<pluginManagement>
7064
<plugins>

shell/pom.xml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,10 @@
2525
<artifactId>groovy-all</artifactId>
2626
</dependency>
2727

28-
<!-- Optional as one does not have to use jline but could use another connector -->
28+
<!-- Will be shaded -->
2929
<dependency>
3030
<groupId>jline</groupId>
3131
<artifactId>jline</artifactId>
32-
<optional>true</optional>
3332
</dependency>
3433

3534
<dependency>
@@ -80,7 +79,6 @@
8079

8180
<build>
8281
<plugins>
83-
<!--
8482
<plugin>
8583
<artifactId>maven-shade-plugin</artifactId>
8684
<version>2.2</version>
@@ -92,11 +90,11 @@
9290
</goals>
9391
<configuration>
9492
<shadedArtifactAttached>false</shadedArtifactAttached>
95-
<createDependencyReducedPom>false</createDependencyReducedPom>
93+
<createDependencyReducedPom>true</createDependencyReducedPom>
94+
<createSourcesJar>true</createSourcesJar>
9695
<artifactSet>
9796
<includes>
9897
<include>jline:jline</include>
99-
<include>org.crashub:crash.cli</include>
10098
</includes>
10199
</artifactSet>
102100
<relocations>
@@ -121,7 +119,7 @@
121119
</execution>
122120
</executions>
123121
</plugin>
124-
-->
122+
125123
<plugin>
126124
<groupId>org.apache.maven.plugins</groupId>
127125
<artifactId>maven-assembly-plugin</artifactId>

shell/src/main/assembly/standalone.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@
3838
<outputDirectory>/</outputDirectory>
3939
<unpack>true</unpack>
4040
<includes>
41+
<!--
4142
<include>jline:jline</include>
43+
-->
4244
<include>org.crashub:crash.cli</include>
4345
<include>org.codehaus.groovy:groovy-all</include>
4446
<include>org.crashub:crash.shell</include>

0 commit comments

Comments
 (0)