Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Form Submission - Mistake (Silver - Custom Comparators and Coordinate Compression) #4992

Closed
maggieliu05 opened this issue Dec 17, 2024 · 4 comments · Fixed by #5017
Closed
Labels
content content-related issue good first issue Good for newcomers

Comments

@maggieliu05
Copy link
Contributor

Someone submitted the contact form!

URL: https://usaco.guide/silver/sorting-custom#comparators
Module: Silver - Custom Comparators and Coordinate Compression
Topic: Mistake
Message:
sorting by multiple criteria, it should be "width != y.width"

@maggieliu05 maggieliu05 added content content-related issue good first issue Good for newcomers labels Dec 17, 2024
@bqi343
Copy link
Member

bqi343 commented Dec 17, 2024

@SansPapyrus683 can you fix? and add a test case to check, since this section has been wrong multiple times ...

@SansPapyrus683
Copy link
Contributor

uh in china so git push like doesn't work for some reason
will get on this when i get back

@ryanchou-dev
Copy link
Member

@SansPapyrus683 can you fix? and add a test case to check, since this section has been wrong multiple times ...

just to clarify, a test case within the code snippet?

@ryanchou-dev ryanchou-dev linked a pull request Dec 31, 2024 that will close this issue
4 tasks
@bqi343
Copy link
Member

bqi343 commented Dec 31, 2024

@ryanchou-dev yes, the codesnip should be able to run on its own (like the ones earlier in the module with main functions) and include a test case showing that the previous comparator and the new one produce different results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content content-related issue good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants