Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve getTemporaryToken logic #1226

Open
ptbrowne opened this issue Feb 2, 2021 · 0 comments
Open

Improve getTemporaryToken logic #1226

ptbrowne opened this issue Feb 2, 2021 · 0 comments
Assignees

Comments

@ptbrowne
Copy link
Contributor

ptbrowne commented Feb 2, 2021

At the moment, we need to have logic in harvest code to know which budget insight endpoint to target. This is brittle since we need to update the code if the endpoint changes, and we can have a discrepancy between the endpoint used by the konnector to create the token, and the endpoint used by the front. See #1225 for a fix that is needed.

What would be better would be that the konnector sends the endpoint + the token when the front runs getTemporaryToken. This way we can remove the endpoint logic from harvest.

Also, it would be better suited to support budget-insight for self hosted Cozys / Gandi cozys (for which domain is not known in advance).

@doubleface doubleface self-assigned this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants