You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The regular contact form and the intents contact form are both in modals, and ideally the submit and cancel buttons would be in the modal footer, fixed.
I tried to do that with preact-portals in (#155) but it didn't work, and I just wanted to document it somewhere.
Closing the creation form modal when the buttons are portaled causes a preact error (something about a parent node not found in a low level function) and then the whole app is broken
The contact form relies on a submit event which needs to be triggered by a submit button. Once the button is portaled elsewhere, I suspect the event doesn't bubble properly and the submit is never fired. While it's possible to manually fire the submit event, this would break keyboard interaction.
So yeah, portals = meh for this. Maybe we should look for a different solution.
The text was updated successfully, but these errors were encountered:
The regular contact form and the intents contact form are both in modals, and ideally the submit and cancel buttons would be in the modal footer, fixed.
I tried to do that with preact-portals in (#155) but it didn't work, and I just wanted to document it somewhere.
submit
button. Once the button is portaled elsewhere, I suspect the event doesn't bubble properly and the submit is never fired. While it's possible to manually fire the submit event, this would break keyboard interaction.So yeah, portals = meh for this. Maybe we should look for a different solution.
The text was updated successfully, but these errors were encountered: