Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact form buttons… elsewhere #157

Open
y-lohse opened this issue May 24, 2018 · 0 comments
Open

Contact form buttons… elsewhere #157

y-lohse opened this issue May 24, 2018 · 0 comments

Comments

@y-lohse
Copy link
Contributor

y-lohse commented May 24, 2018

The regular contact form and the intents contact form are both in modals, and ideally the submit and cancel buttons would be in the modal footer, fixed.

I tried to do that with preact-portals in (#155) but it didn't work, and I just wanted to document it somewhere.

  • Closing the creation form modal when the buttons are portaled causes a preact error (something about a parent node not found in a low level function) and then the whole app is broken
  • The contact form relies on a submit event which needs to be triggered by a submit button. Once the button is portaled elsewhere, I suspect the event doesn't bubble properly and the submit is never fired. While it's possible to manually fire the submit event, this would break keyboard interaction.

So yeah, portals = meh for this. Maybe we should look for a different solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant