Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: in Watchtower/Composable CoW, stress that reverting with unknown errors causes order polling to stop #325

Open
fedgiac opened this issue Feb 9, 2024 · 0 comments
Open

chore: in Watchtower/Composable CoW, stress that reverting with unknown errors causes order polling to stop #325

fedgiac opened this issue Feb 9, 2024 · 0 comments

Comments

@fedgiac
Copy link
Contributor

fedgiac commented Feb 9, 2024

Background

The watchtower uses custom revert messages to determine if it should continue to create orders.
If the revert bytes don't decode to a known error, polling stop.
This can happen in unexpected circumstances, like overflow because of weird rounding.

Details

Related watchtower issue.

Acceptance criteria
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fedgiac