Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It looks like coveralls-api-result is no longer used #193

Closed
StummeJ opened this issue Oct 13, 2023 · 7 comments
Closed

It looks like coveralls-api-result is no longer used #193

StummeJ opened this issue Oct 13, 2023 · 7 comments

Comments

@StummeJ
Copy link

StummeJ commented Oct 13, 2023

As the title says, the v2 tags look like the coveralls-api-result output is no longer used, giving a false pretense that we can act based on the results of the action

@muneeb706
Copy link

muneeb706 commented Jan 6, 2024

There is a troubleshooting section in the README that addresses this issue. After going through the steps mentioned, I was able to view the coveralls api response in logs. In my case, I had to enable LEAVE COMMENTS in repo settings page in Coveralls app.

However, after migrating to V2 from V1. I am unable to view coverage results in PR conversations tab.

@fletort
Copy link

fletort commented Oct 17, 2024

Yes the output of the action seems not available.
In the file action.yml, we see that hey are any output defined....
It was remove in the PR #204

@StummeJ
Copy link
Author

StummeJ commented Oct 17, 2024

Closing since it's no longer specified in the action

@StummeJ StummeJ closed this as completed Oct 17, 2024
@fletort
Copy link

fletort commented Oct 17, 2024

But it is specified in the readme... so they are a problem....
Remove from the Readme, or make working again this output that can be very interesting....

@afinetooth
Copy link
Member

@fletort @StummeJ @muneeb706 I have commented out the outdated v1.x content re: coveralls-api-result from the current README (for v2).

I am not personally familiar with coveralls-api-result from v1 as our sole output option, but if you feel it should be part of the action, please open a new issue with the request, and anything you can share about how it used to work, or how it should work in your opinion, and about your use case, would be a big help. 🙏

@muneeb706
Copy link

@afinetooth

I experienced an issue while trying to view coverage details in the GitHub Pull Request's conversation tab. After investigation, I discovered that the problem was in my configuration - I had been pointing to the master branch instead of specifying a particular version. Since I was expecting v1 behavior while the repository had been updated to v2, some recent updates were not incorporated into my scripts. After explicitly switching to v2 in my configuration, the coverage details are now displaying correctly in the PR conversation tab, and everything is working as expected.

Thank you

@afinetooth
Copy link
Member

You’re welcome, @muneeb706. Glad to hear it.

Just to reiterate for anyone checking this issue and still confused about how our versions are organized:

  • v1 lives in master; and
  • v2 lives in main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants