Better loading failure mode

[solarkraft]

Discovered while working on my DokuWiki distribution:

When an error occurs, the promised redirection never happens and, due to the cookie, it will always attempt and fail to open the visual editor.

In the video you see it switching back to the text editor once, I am not sure why.

Screen.Recording.2021-08-23.at.18.40.15-2.mov

Suggested solutions to avoid bricking the editor:

• Only set the cookie after the editor has successfully loaded
• Reset the cookie on error
• Instruct the user to clear cookies (and avoid the visual editor)

The actual error is likely in the way I install the plugin, so I track it in my repo.

[solarkraft]

The TL;DR solution/workaround for the most common version of this problem is install from the release, not the source (as there is javascript that needs to be compiled).

Maybe the error message should point to an internal error with the possible cause of a wrong installation. It can also be an error in some other plugin's script though, since due to the bundling a single one will take down the JS of the whole page.

The suggestions above still apply, which is why I'm keeping this issue open.