Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalFileHistoryFinder.GetManifestFilenames() should return relative paths #629

Open
doughertym opened this issue May 31, 2023 · 0 comments · May be fixed by #632
Open

LocalFileHistoryFinder.GetManifestFilenames() should return relative paths #629

doughertym opened this issue May 31, 2023 · 0 comments · May be fixed by #632
Assignees
@doughertym
Labels
bug Something isn't working

Comments

@doughertym
Copy link
Contributor

When the LocalFileHistoryFinder is used, the GetManifestFilenames() currently returns just the filename. However, this can cause issues if there are manifest files located further down the tree than the top-level. For example corgibytes/freshli-fixture-csharp-test:directory/TestProjectInDirectory.csproj will be returned as TestProjectInDirectory.csproj.
@doughertym doughertym moved this to Backlog in Freshli May 31, 2023
@doughertym doughertym moved this from Backlog to To Do in Freshli May 31, 2023
@doughertym doughertym self-assigned this May 31, 2023
@doughertym doughertym moved this from To Do to In Progress in Freshli May 31, 2023
@doughertym doughertym added the bug Something isn't working label May 31, 2023
doughertym added a commit that referenced this issue May 31, 2023
@doughertym
make local history files relative to analysis path
850a5be 
Resolves #629
@doughertym doughertym linked a pull request May 31, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doughertym doughertym

Labels
bug Something isn't working
Projects
Freshli
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #629: Local file finder should return relative paths corgibytes/freshli-lib
1 participant
@doughertym