Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VersionsBetween() should use less than 5 arguments #236

Open
dfar-io opened this issue Feb 15, 2021 · 0 comments
Open

VersionsBetween() should use less than 5 arguments #236

dfar-io opened this issue Feb 15, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@dfar-io
Copy link
Contributor

dfar-io commented Feb 15, 2021 •
edited
Loading

When checking against VersionsBetween(), we use 5 arguments which should be reduced to 4 or less.

I'm thinking maybe put the package name into IVersionInfo?

When working on this issue, remove the file NuGetRepository.cs from exclude_files to correctly measure the code maintainability changes.
@dfar-io dfar-io added the bug Something isn't working label Feb 15, 2021
@dfar-io dfar-io self-assigned this Feb 15, 2021
@dfar-io dfar-io mentioned this issue Feb 15, 2021
Merged
@dfar-io dfar-io removed their assignment Feb 17, 2021
@mscottford mscottford moved this to Backlog in Freshli Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Freshli
Status: Icebox
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dfar-io