Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullable reference types warning #199

Open
nickiemc opened this issue Dec 15, 2020 · 3 comments · Fixed by #213
Open

Fix nullable reference types warning #199

nickiemc opened this issue Dec 15, 2020 · 3 comments · Fixed by #213
Assignees
@dan-hein
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nickiemc
Copy link
Contributor

When building, the following warning is produced:

Languages/Python/Conversions.cs(29,74): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

This warning should be addressed.
@dan-hein dan-hein self-assigned this Jan 12, 2021
dan-hein added a commit that referenced this issue Jan 12, 2021
@dan-hein
Enables Nullability for PythonVersionInfo
70bb764 
Annotates the PythonVersionInfo class to enable nullable references. This clears the warning and indicates intent to work with nullable references. C# 8.0 added this annotation to allow for fine-grain control on the nullability of references. This annotation also allows for the change to the SafeToLower and SafeExtract methods, that can potentially return null, to return Nullable strings which further enables null-safe checking.

See Microsoft's documentation https://docs.microsoft.com/en-us/dotnet/csharp/nullable-references#nullable-annotation-context

Resolves #199
@dan-hein dan-hein mentioned this issue Jan 12, 2021
Merged
@nickiemc nickiemc reopened this Jan 13, 2021
@mrbiggred mrbiggred added the bug Something isn't working label Feb 2, 2021
@mrbiggred
Copy link
Contributor

@dan-hein I noticed that @nickiemc re-opened this case. Can you take a look to see if PR #213 actually fixed this issue or not? Thanks.

@dan-hein
Copy link
Contributor

dan-hein commented Feb 3, 2021

Hey @mrbiggred, I believe Nickie did that just to mark the task as Ready for Deployment. The changes attached should fix the issue described. I think that was mainly for the Freshli board.

@nickiemc
Copy link
Contributor Author

nickiemc commented Feb 4, 2021

@dan-hein @mrbiggred Correct. GitHub automatically closed the issue because of the Resolves keyword in PR #213. But since it still hasn't been deployed to production, I reopened it and moved to Ready for Deployment.

@mscottford mscottford added the good first issue Good for newcomers label Oct 7, 2021
@mscottford mscottford moved this to Backlog in Freshli Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dan-hein dan-hein

Labels
bug Something isn't working good first issue Good for newcomers
Projects
Freshli
Status: Icebox
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enables Nullability for PythonVersionInfo corgibytes/freshli-lib
4 participants
@mscottford @dan-hein @nickiemc @mrbiggred