Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dashes and underscores in Python version numbers #163

Open
nickiemc opened this issue Oct 16, 2020 · 1 comment
Open

Add support for dashes and underscores in Python version numbers #163

nickiemc opened this issue Oct 16, 2020 · 1 comment
Labels
enhancement New feature or request python Parsing Python dependencies

Comments

@nickiemc
Copy link
Contributor

Non-normalized Python versions can include dashes (-) and underscores (_) in place of periods (.).

PythonVersionInfo should be updated to allow these characters.

@nickiemc nickiemc added enhancement New feature or request python Parsing Python dependencies labels Oct 16, 2020
@nickiemc
Copy link
Contributor Author

Relevant error messages from https://github.com/explosion/spaCy:

Error adding version to regex release history: Unable to parse version string:   '2013-02-16'.
Error adding version to regex release history: Unable to parse version string: '2013-02-23'.
Error adding version to regex release history: Unable to parse version string: '2013-03-11'.
Error adding version to regex release history: Unable to parse version string: '2013-05-21'.
Error adding version to regex release history: Unable to parse version string: '2013-06-05'.
Error adding version to regex release history: Unable to parse version string: '2013-06-26'.
Error adding version to regex release history: Unable to parse version string: '2013-08-04'.
Error adding version to regex release history: Unable to parse version string: '2013-10-04'.
Error adding version to regex release history: Unable to parse version string: '2013-10-12'.
Error adding version to regex release history: Unable to parse version string: '2013-10-21'.
Error adding version to regex release history: Unable to parse version string: '2013-10-22'.
Error adding version to regex release history: Unable to parse version string: '2013-10-23'.
Error adding version to regex release history: Unable to parse version string: '2013-10-24'.
Error adding version to regex release history: Unable to parse version string: '2013-10-25'.
Error adding version to regex release history: Unable to parse version string: '2013-10-26'.
Error adding version to regex release history: Unable to parse version string: '2013-11-29'.
Error adding version to regex release history: Unable to parse version string: '2013-12-31'.

Note: This is not actually causing an analysis error in the spaCy as none of these versions are used by spaCy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Parsing Python dependencies
Projects
Status: Icebox
Development

No branches or pull requests

1 participant