Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate version number comparisons to language agents #685

Open
mscottford opened this issue Sep 18, 2023 · 1 comment
Open

Delegate version number comparisons to language agents #685

mscottford opened this issue Sep 18, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@mscottford
Copy link
Member

Different language ecosystems have different rules about version number formatting, valid syntax, sorting, and equivalence. It's unrealistic to expect the core CLI to correctly handle all of these differences.

A new gRPC method should be added to the language agent specification that can be used to compare two version strings, CompareVersions(string, string). This will behave similarly to typical compare functions:

  • If the two values are equivalent, then the result will be 0.
    • The strings do not need to be equal to be equivalent. 1.0 is likely equivalent to 1.0.0.0, but ecosystem rules should be used to make that determination.
  • If the first value is less than the second value, then the result will be less than 0.
  • If the first value is greater than the second value, then the result will be greater than 0.
@mscottford mscottford added this to the v0.8.0 milestone Sep 18, 2023
@mscottford mscottford added the enhancement New feature or request label Sep 18, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Freshli Sep 18, 2023
@mscottford mscottford moved this from Backlog to To Do in Freshli Sep 18, 2023
@mscottford mscottford moved this from To Do to Backlog in Freshli Sep 18, 2023
@mscottford
Copy link
Member Author

This should be competed before corgibytes/freshli#19 is considered complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant