Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include path for SVG files in Flag icons is incorrect #22

Open
jaydiablo opened this issue Jun 10, 2020 · 6 comments
Open

Include path for SVG files in Flag icons is incorrect #22

jaydiablo opened this issue Jun 10, 2020 · 6 comments

Comments

@jaydiablo
Copy link

This is similar to #20 but for the Flag icons.

The path defined here: https://github.com/coreui/coreui-icons/blob/master/scss/flag/_core.scss#L14 isn't quite right because the svg folder is actually one level deeper. This error was emitted when transpiling the SCSS:

Syntax Error: ModuleNotFoundError: Module not found: Error: Can't resolve '../svg/flag/cif-ad.svg' in '/project/node_modules/@coreui/icons/scss/flag'

To fix this, I changed this line:

background-image: url(../svg/flag/#{$coreui-icons-prefix}#{$icon}.svg);

to

background-image: url(../../svg/flag/#{$coreui-icons-prefix}#{$icon}.svg);

@patdec
Copy link

patdec commented Jul 21, 2020

Same issue for CoreUI Icons PRO. Can you fix it. Please

@mrholek
Copy link
Member

mrholek commented Jul 21, 2020

Sure, I will check it ASAP

@Letrab
Copy link

Letrab commented Aug 21, 2020

@mrholek , any update on fixing this (in PRO)? Thanks!

@mrholek
Copy link
Member

mrholek commented Nov 18, 2020

@jaydiablo @patdec I fixed it in the latest release, can you check if this release is ok?

@patdec
Copy link

patdec commented Nov 30, 2020

@mrholek release 2.0.0-rc.0 isn't accessible from npm registry:
https://registry.npmjs.org/@coreui/icons-pro/

@linkuha
Copy link

linkuha commented Mar 13, 2021

@mrholek when will be update in npm ? cloning from git is not a suitable option (also spending a lot of disk space)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants