Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging/spec.in: Enable rpm-ostree-countme.timer following presets #4548

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

travier
Copy link
Member

@travier travier commented Aug 24, 2023

Use systemd macros to enable/disable the rpm-ostree-countme.timer unit following the global systemd presets.

This fixes the timer enablement on systems that do no preset-all like Fedora CoreOS.

See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd

@travier
Copy link
Member Author

travier commented Aug 24, 2023

@cgwalters
Copy link
Member

Huh, somehow this breaks the RPM build:

[2023-08-24T17:33:52.769Z] error: Could not open %files file /home/jenkins/agent/workspace/rpm-ostree_PR-4548/rpm-ostree-2023.5.62.gb7e8c14e/files: No such file or directory

Use systemd macros to enable/disable the rpm-ostree-countme.timer unit
following the global systemd presets.

This fixes the timer enablement on systems that do no preset-all like
Fedora CoreOS.

See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd
@cgwalters
Copy link
Member

/override ci/prow/fcos-e2e
Infra flake, not worth retesting

@cgwalters cgwalters merged commit 94b039a into coreos:main Aug 25, 2023
13 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/fcos-e2e

In response to this:

/override ci/prow/fcos-e2e
Infra flake, not worth retesting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier travier deleted the spec-presets branch August 28, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants