This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
[NOT TESTED] Support running as init container #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It make more sense to run the installation as a init container, instant of installing and then sleeping forever. The old behavior is still supported by setting: CNI_INSTALL_TYPE=container Require k8s 1.6< Fix #8
|
lgtm |
jpiper
reviewed
Feb 21, 2018
| valueFrom: | ||
| configMapKeyRef: | ||
| name: kube-flannel-cfg | ||
| key: cni-conf.json |
There was a problem hiding this comment.
this block of yaml isn't valid. You want
env:
- name: CNI_NETWORK_CONFIG
valueFrom:
configMapKeyRef:
name: kube-flannel-cfg
key: cni-conf.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It make more sense to run the installation as a init container,
instant of installing and then sleeping forever.
The old behavior is still supported by setting:
CNI_INSTALL_TYPE=container
Require k8s 1.6<
Fix #8
I'm not sure if this should be opt-in or opt-out? Any input?