This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
build cni for more than just amd64 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change non-amd64 containers contained amd64 binaries. This commit changes this behaviour. Some architectures like arm64 or amd64 report themself different with 'uname -m', thus this needs mapping to the architecture named packages of cni and cni-plugins.
Signed-off-by: Martin Zobel-Helas <[email protected]>
Signed-off-by: Martin Zobel-Helas <[email protected]>
4 tasks
|
Would it be possible to take a look at this? It appears to be a blocker for |
xin3liang
approved these changes
Dec 30, 2019
xin3liang
approved these changes
Dec 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change non-amd64 containers contained amd64 binaries. This
commit changes this behaviour. Some architectures like arm64 or amd64
report themself different with 'uname -m', thus this needs mapping to
the architecture named packages of cni and cni-plugins.
This should fix #10.