Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License unclear #2

Open
lutostag opened this issue Dec 23, 2024 · 1 comment
Open

License unclear #2

lutostag opened this issue Dec 23, 2024 · 1 comment

Comments

@lutostag
Copy link

Hey there, @copyleftdev,

This x12 library looks really efficient and well laid out for slicing and dicing x12 data! Way better than some of the other non python3+ libs out there.

In your readme you have that "Contributions are welcome", but you do not have any clear license for this library.

In some of your other code, you have it clearly licensed as MIT (e.g. https://github.com/copyleftdev/5l4pp3r?tab=readme-ov-file#-license). Here you have it listed as "License :: OSI Approved :: MIT License" in the setup.cfg

Are you able to provide guidance as to how you are looking to license this code, and if so add a LICENSE file to this repo for clarity?

Appreciate it!

@copyleftdev
Copy link
Owner

Hey @lutostag!

Thanks so much for checking out the library and for the kind words. You’re absolutely right—it would be clearer to explicitly include the license. I’ve just pushed an update adding an MIT License file (similar to my other repos), and I’ve updated the README to reflect that contributions are welcome under MIT.

Appreciate the heads-up and I look forward to any feedback or PRs you might have!

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants