Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should a user supply data in its original or log-transformed form #109

Open
pgkirsch opened this issue Jul 29, 2021 · 1 comment
Open

Should a user supply data in its original or log-transformed form #109

pgkirsch opened this issue Jul 29, 2021 · 1 comment

Comments

@pgkirsch
Copy link
Contributor

GPfit has always taken log-transformed data as its input, which adds a couple lines to a user's script. Is there a good reason for this or should it take untransformed data as the input given that is ultimately what an end user cares about? @whoburg particularly curious if there was a strong reason for wanting to do it this way originally?

@pgkirsch pgkirsch modified the milestone: v0.2 Jul 29, 2021
@whoburg
Copy link
Collaborator

whoburg commented Jul 29, 2021

@pgkirsch here's my argument for taking in log-transformed data

The fit will only be successful if the data are "approximately log-convex". Allowing users to supply untransformed data might give the wrong impression, as if GPfit can handle any data one might throw at it. Taking in log-transformed data also eliminates the possibility that the data can't even be log-transformed (negative values), and maybe encourages users to at least look at the log-transformed version of their data.

That's my pitch. willing to hear other views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants