Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication of _Fit.params and _Fit.parameters #106

Open
pgkirsch opened this issue Jul 28, 2021 · 3 comments
Open

Remove duplication of _Fit.params and _Fit.parameters #106

pgkirsch opened this issue Jul 28, 2021 · 3 comments
Labels

Comments

@pgkirsch
Copy link
Contributor

params is array, parameters is a dictionary, both have some value but the similar names are confusing.

@whoburg
Copy link
Collaborator

whoburg commented Jul 29, 2021

believe the parameters name came from Levenberg–Marquardt literature

@pgkirsch
Copy link
Contributor Author

I figured there was a good precedent for it. My issue isn't with our use of parameters, rather that I clumsily introduced a new attribute parameters while we still also have params (the variable name that has been around since OG GPfit). Lazy on my part and needs to be deconflicted, just not sure how best to do it yet.

@whoburg
Copy link
Collaborator

whoburg commented Jul 29, 2021

gotcha, sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants