test/system: Use a variable for the container name

#1715

Author: debarshiray

test/system/101-create.bats

@@ -50,23 +50,27 @@ teardown() {
 @test "create: With a custom name (using option --container)" {
   pull_default_image
 
-  run --separate-stderr "$TOOLBX" create --container "custom-containerName"
+  local container="custom-containerName"
+
+  run --separate-stderr "$TOOLBX" create --container "$container"
 
   assert_success
-  assert_line --index 0 "Created container: custom-containerName"
-  assert_line --index 1 "Enter with: toolbox enter custom-containerName"
+  assert_line --index 0 "Created container: $container"
+  assert_line --index 1 "Enter with: toolbox enter $container"
   assert [ ${#lines[@]} -eq 2 ]
   assert [ ${#stderr_lines[@]} -eq 0 ]
 }
 
 @test "create: With a custom image and name (using option --container)" {
   pull_distro_image fedora 34
 
-  run --separate-stderr "$TOOLBX" create --container "fedora34" --image fedora-toolbox:34
+  local container="fedora34"
+
+  run --separate-stderr "$TOOLBX" create --container "$container" --image fedora-toolbox:34
 
   assert_success
-  assert_line --index 0 "Created container: fedora34"
-  assert_line --index 1 "Enter with: toolbox enter fedora34"
+  assert_line --index 0 "Created container: $container"
+  assert_line --index 1 "Enter with: toolbox enter $container"
   assert [ ${#lines[@]} -eq 2 ]
   assert [ ${#stderr_lines[@]} -eq 0 ]
 }
@@ -143,15 +147,17 @@ teardown() {
 
   pull_distro_image arch latest
 
+  local container="arch-toolbox-latest"
+
   run --separate-stderr "$TOOLBX" create --distro arch
 
   assert_success
-  assert_line --index 0 "Created container: arch-toolbox-latest"
+  assert_line --index 0 "Created container: $container"
 
   if [ "$system_id" = "arch" ]; then
     assert_line --index 1 "Enter with: toolbox enter"
   else
-    assert_line --index 1 "Enter with: toolbox enter arch-toolbox-latest"
+    assert_line --index 1 "Enter with: toolbox enter $container"
   fi
 
   assert [ ${#lines[@]} -eq 2 ]
@@ -160,7 +166,7 @@ teardown() {
   run podman ps --all
 
   assert_success
-  assert_output --regexp "Created[[:blank:]]+arch-toolbox-latest"
+  assert_output --regexp "Created[[:blank:]]+$container"
 }
 
 @test "create: Arch Linux ('--release latest')" {