You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
c/image calls chunked.GetDiffer immediately followed by store.ApplyDiffWithDiffer ~ differ.ApplyDiff.
Currently convert_images happens in the latter call; but that means it happens with the layer store locked for writing. It seems to me that moving the conversion to the GetDiffer phase would increase opportunities for concurrency, especially for slow networks. (And it would probably simplify the data stored in chunkedDiffer and the ApplyDiff implementation a bit.)
Cc: @giuseppe . This is certainly not urgent, and might even not be desirable to do right now — but I hear performance of this code path is a concern, so this might be worth considering.
The text was updated successfully, but these errors were encountered:
c/image calls
chunked.GetDiffer
immediately followed bystore.ApplyDiffWithDiffer
~differ.ApplyDiff
.Currently
convert_images
happens in the latter call; but that means it happens with the layer store locked for writing. It seems to me that moving the conversion to theGetDiffer
phase would increase opportunities for concurrency, especially for slow networks. (And it would probably simplify the data stored inchunkedDiffer
and theApplyDiff
implementation a bit.)Cc: @giuseppe . This is certainly not urgent, and might even not be desirable to do right now — but I hear performance of this code path is a concern, so this might be worth considering.
The text was updated successfully, but these errors were encountered: